E-Document Import - check length for GTIN#6806
Merged
Groenbech96 merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
darjoo
approved these changes
Feb 25, 2026
VolodySyn
approved these changes
Feb 25, 2026
Groenbech96
added a commit
that referenced
this pull request
Feb 27, 2026
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This pr adds a check that ensures that an invalid gtin dont fail the setrange. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#622663](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622663) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
Groenbech96
added a commit
that referenced
this pull request
Feb 27, 2026
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This pr adds a check that ensures that an invalid gtin dont fail the setrange. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#622663](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/622663) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
This was referenced Feb 27, 2026
Groenbech96
added a commit
that referenced
this pull request
Feb 27, 2026
## Summary - Backport of #6806 to releases/28.x - Adds a check that ensures an invalid GTIN (longer than the field length) doesn't fail the SetRange when importing E-Documents. Fixes [AB#623326](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623326) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
Groenbech96
added a commit
that referenced
this pull request
Feb 27, 2026
## Summary - Backport of #6806 to releases/28.0 - Adds a check that ensures an invalid GTIN (longer than the field length) doesn't fail the SetRange when importing E-Documents. Fixes [AB#623325](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623325) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds a check that ensures that an invalid gtin dont fail the setrange.
Work Item(s)
Fixes AB#622663